Skip to content

Conversation

@RubenVerborgh
Copy link
Contributor

@RubenVerborgh RubenVerborgh commented Aug 6, 2019

No description provided.

@dmitrizagidulin
Copy link
Member

(Big thumbs up for this PR in general, I think this is an important section.)

Copy link
Member

@kjetilk kjetilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few inline comments, other than that, it looks good.

@RubenVerborgh RubenVerborgh requested a review from kjetilk August 7, 2019 14:07
Copy link
Member

@kjetilk kjetilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, sounds good. I added #27 to address the upgrade mechanism.

Copy link
Member

@acoburn acoburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Setting range request support at MAY makes a lot of sense to me (Trellis supports range requests for LDP-NR resources only)

Copy link
Member

@csarven csarven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@justinwb justinwb requested review from TallTed and justinwb August 9, 2019 21:18
Copy link
Member

@justinwb justinwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great 👍

@justinwb justinwb removed the request for review from TallTed August 9, 2019 21:22
Copy link

@pmcb55 pmcb55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me (with caveat on #14!).

@RubenVerborgh RubenVerborgh merged commit 62e89e9 into master Aug 29, 2019
@RubenVerborgh RubenVerborgh deleted the feature/http branch August 29, 2019 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: editorial Concerns phrasing/wording doc: Protocol

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants