Fixing AppendFormat issue + unit tests#300
Merged
danjagnow merged 1 commit intosolarwinds:masterfrom Oct 4, 2021
superzer0:feature/NCM-7385-fixed-append-format
Merged
Fixing AppendFormat issue + unit tests#300danjagnow merged 1 commit intosolarwinds:masterfrom superzer0:feature/NCM-7385-fixed-append-format
danjagnow merged 1 commit intosolarwinds:masterfrom
superzer0:feature/NCM-7385-fixed-append-format
Conversation
bzab-sw
approved these changes
Oct 4, 2021
danjagnow
approved these changes
Oct 4, 2021
Contributor
danjagnow
left a comment
There was a problem hiding this comment.
Looks good! Thanks for adding StringBuilderExtensionsTests.
|
|
||
| if (entity.IsIndication) | ||
| { | ||
|
|
Contributor
There was a problem hiding this comment.
Minor: Why the blank line here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://jira.solarwinds.com/browse/NCM-8025
System.FormatException: Input string was not in a correct format. at System.Text.StringBuilder.FormatError() at System.Text.StringBuilder.AppendFormatHelper(IFormatProvider provider, String format, ParamsArray args) at System.Text.StringBuilder.AppendFormat(String format, Object[] args) at SwqlStudio.DocumentationBuilder.ToToolTip(ITypedMetadata metadata, IObsoleteMetadata obsoleteMetadata) at SwqlStudio.TreeNodesBuilder.AddPropertiesToNode(IMetadataProvider provider, TreeNode entityNode, IEnumerable1 properties)`