Find and Replace dialog fixes#274
Conversation
It looks better, especially on a high DPI screen
The result was a corrupted text
| // | ||
| // openFileDialog | ||
| // | ||
| this.openFileDialog.FileName = "openFileDialog1"; |
There was a problem hiding this comment.
Not really related to the "Find and Replace" dialog, but why not fix it anyway.
| if (rdoRegexR.Checked) | ||
| { | ||
| rr = new Regex(txtFindR.Text, GetRegexOptions()); | ||
| string selRangeText = Scintilla.GetTextRange(selRange.cpMin, selRange.cpMax - selRange.cpMin + 1); |
There was a problem hiding this comment.
Example of bad replace:
- query:
abc - search for regex:
b - replace with:
d - result was:
adcc
|
The dialog contains surprisingly lot of duplicated or unfinished code and copy-paste issues. This PR should fix the ones I encountered. What are the plans for the whole "ScintillaNET-FindReplaceDialog" component? Do only as few changes as possible? Delete everything we don't use (IncrementalSearch, FindAllResults, GoTo)? Refactor the code we use to simplify it? Are changes like this even OK, considering it's a 3rd-party code? |
|
Changes are available for testing in build 3.0.0.312 |
tdanner
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up. Since we have copied this code into this project (can't remember who added this feature), we should fix problems like this.
A bunch of fixes for issues in the "Find and Replace" dialog. One commit per issue.