Add OpenTelemetry attributes to the metrics backend#2327
Merged
adamw merged 2 commits intosoftwaremill:masterfrom Oct 30, 2024
Merged
Add OpenTelemetry attributes to the metrics backend#2327adamw merged 2 commits intosoftwaremill:masterfrom
adamw merged 2 commits intosoftwaremill:masterfrom
Conversation
Contributor
Author
|
@adamw Have a review on it at your free time |
adamw
reviewed
Oct 29, 2024
...-metrics-backend/src/main/scala/sttp/client4/opentelemetry/OpenTelemetryMetricsBackend.scala
Show resolved
Hide resolved
adamw
reviewed
Oct 29, 2024
...rics-backend/src/test/scala/sttp/client4/opentelemetry/OpenTelemetryMetricsBackendTest.scala
Outdated
Show resolved
Hide resolved
adamw
reviewed
Oct 29, 2024
Member
|
Thanks - the PR looks good! I've left a couple of minor comments before we merge |
...-metrics-backend/src/main/scala/sttp/client4/opentelemetry/OpenTelemetryMetricsBackend.scala
Outdated
Show resolved
Hide resolved
...-metrics-backend/src/main/scala/sttp/client4/opentelemetry/OpenTelemetryMetricsBackend.scala
Outdated
Show resolved
Hide resolved
aa92977 to
3ed2680
Compare
...-metrics-backend/src/main/scala/sttp/client4/opentelemetry/OpenTelemetryMetricsBackend.scala
Show resolved
Hide resolved
Contributor
Author
|
@adamw Done! Added review comments |
Contributor
Author
|
@adamw Can it be merged now? |
Member
|
@varshith257 Yes, all done, thanks :) |
Contributor
Author
|
@adamw Any communication channel to connect with you? I have some doubts regarding implementation of other issue works AFAIK Discourse is the one? |
Member
|
@varshith257 I think it would be best to keep the discussions on the appropriate GH issue, otherwise there's softwaremill.community Discourse and Scala Space's Discord |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting pull request:
sbt compilesbt compileDocssbt testsbt scalafmtCloses #2292
/claim #2292