Skip to content

link macro call items source code#2915

Merged
FroyaTheHen merged 1 commit intomainfrom
spr/main/f121e979
Jan 14, 2026
Merged

link macro call items source code#2915
FroyaTheHen merged 1 commit intomainfrom
spr/main/f121e979

Conversation

@FroyaTheHen
Copy link
Contributor

@FroyaTheHen FroyaTheHen commented Dec 17, 2025 •
edited
Loading

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

closes #2137

@FroyaTheHen FroyaTheHen mentioned this pull request Dec 18, 2025
Merged
@FroyaTheHen FroyaTheHen force-pushed the spr/main/f121e979 branch 2 times, most recently from ea6b1a2 to d470e01 Compare December 18, 2025 06:12
@FroyaTheHen FroyaTheHen self-assigned this Dec 18, 2025
@FroyaTheHen FroyaTheHen marked this pull request as ready for review December 18, 2025 06:27
@FroyaTheHen FroyaTheHen requested a review from a team as a code owner December 18, 2025 06:27
maciektr
maciektr requested changes Jan 8, 2026
View reviewed changes
Copy link
Contributor

@maciektr maciektr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure where the cause is, so posting here

When I generate docs for contracts, I get invalid link on ContractState
See the example below:

For this contract: https://github.com/OpenZeppelin/cairo-contracts/blob/main/packages/presets/src/erc1155.cairo#L11-L97
I get two structs:
image

While the Storage link points to source correctly: https://github.com/OpenZeppelin/cairo-contracts/blob/main/packages/presets/src/erc1155.cairo#L38-L48

The ContractState one is gibberish and points to nothing: https://github.com/OpenZeppelin/cairo-contracts/blob/main/packages/presets/src/erc1155.cairo:38:5:%2048:6[contract]#L61-L70

Base automatically changed from spr/main/dad9125f to main January 12, 2026 05:19
This was referenced Jan 13, 2026
Closed
Closed
@FroyaTheHen FroyaTheHen marked this pull request as draft January 14, 2026 05:15
@FroyaTheHen
Copy link
Contributor Author

FroyaTheHen commented Jan 14, 2026 •
edited
Loading

not FileLongId::OnDisk have gibberish paths, the new approach (this PR already updated) should prevent that from happening. The items that are not explicitly declared but a result of generating/expanding will now link to the closest OnDisk ancestor.
cc @maciektr

@FroyaTheHen FroyaTheHen marked this pull request as ready for review January 14, 2026 07:00
@FroyaTheHen FroyaTheHen merged commit 9608e83 into main Jan 14, 2026
16 of 29 checks passed
@FroyaTheHen FroyaTheHen deleted the spr/main/f121e979 branch January 14, 2026 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maciektr maciektr maciektr approved these changes

Assignees

@FroyaTheHen FroyaTheHen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bundle project source code with docs and link to it in item's documentation

2 participants

@FroyaTheHen @maciektr