added Marker component to definition file#1209
added Marker component to definition file#1209msand merged 1 commit intosoftware-mansion:developfrom SaeedZhiany:FixMarkerTypeDefinition
Conversation
|
@msand |
|
Great, thanks for this! The marker props apply to all shapes: https://www.w3.org/TR/SVG/shapes.html#TermShapeElement |
|
@msand My concern on this PR is fixing the building crash when using of Marker component and the typescript error TS2322 when passing marker(Start/Mid/End) props to a shape component like Path. |
|
No need to refactor at this point, they shouldn't hurt afaik, can make another pr/issue if anything shows up. Thanks for this! |
|
🎉 This PR is included in version 9.13.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@msand My question was about the Marker props that already supported in code and must be added to props of components like Path and the other shapes you mentioned before to fix TS2322 error message. The props I could find are |
|
Oh, my mistake, was rushing thru the PRs as I barely have any time to dedicate to this project atm. |
|
@msand I'll make another draft PR with your suggestion and I'll inform you. |
|
yeah, or with the addition of the default marker prop: export interface CommonMarkerProps {
marker?: string;
markerStart?: string;
markerMid?: string;
markerEnd?: string;
}
export interface CommonPathProps
extends FillProps,
StrokeProps,
ClipProps,
TransformProps,
VectorEffectProps,
ResponderProps,
TouchableProps,
DefinitionProps,
CommonMarkerProps,
CommonMaskProps {} |
|
I'll send you a PR in a few seconds. |
Summary
This PR adding missing Marker related type definition. fixes #1208
Test Plan
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.mdCHANGELOG.mdexample/App.js)