Invalidate display link instead of pausing it when invalidating the nodes manager#3090
Merged
piaskowyk merged 1 commit intosoftware-mansion:mainfrom Apr 1, 2022
Merged
Conversation
…odes manager Pausing the display link on invalidation will still make it call the onAnimationFrame selector one more time as its already schedule. When this happens animation blocks will be called and crash while accessing the jsi runtime thats already dealloced.
kmagiera
approved these changes
Mar 22, 2022
piaskowyk
approved these changes
Apr 1, 2022
Member
piaskowyk
left a comment
There was a problem hiding this comment.
Thanks for the help I really appreciate that! ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Invalidate display link instead of pausing it when invalidating the nodes manager
Pausing the display link on invalidation will still make it call the onAnimationFrame selector one more time as its already schedule. When this happens animation blocks will be called and crash while accessing the jsi runtime thats already dealloced.
Fixes #2035
Fixes #2899
Test code and steps to reproduce
See #2035 for reproduction