Skip to content

Source build: don't hardcode build dir#3053

Merged
piaskowyk merged 1 commit intosoftware-mansion:mainfrom
th3rdwave:sb-build-dir
Mar 8, 2022
Merged

Source build: don't hardcode build dir#3053
piaskowyk merged 1 commit intosoftware-mansion:mainfrom
th3rdwave:sb-build-dir

Conversation

@janicduplessis
Copy link
Copy Markdown
Contributor

Description

It is possible to change the gradle build dir so it is not safe to assume it will be under /build.

Changes

Use the project build dir from gradle in cmake instead of assuming /build.

Screenshots / GIFs

N/A

Test code and steps to reproduce

android/build.gradle

allprojects {
    buildDir = "${System.getProperty("user.home")}/.gradle/builds/${rootProject.name}/${project.name}"
}

Checklist

  • Included code example that can be used to test this change
  • Updated TS types
  • Added TS types tests
  • Added unit / integration tests
  • Updated documentation
  • Ensured that CI passes

Copy link
Copy Markdown
Member

@piaskowyk piaskowyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@piaskowyk piaskowyk merged commit 6f8333d into software-mansion:main Mar 8, 2022
@janicduplessis janicduplessis deleted the sb-build-dir branch March 8, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants