Skip to content

Fix unused setter argument warning #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
soffes merged 1 commit into from
Jun 2, 2023
Merged

Fix unused setter argument warning #22

soffes merged 1 commit into from
Jun 2, 2023

Conversation

@msanders
Copy link
Contributor

@msanders msanders commented Feb 2, 2020

Fixes:

Sources/HotKey/KeyCombo.swift:26:22: warning: setter argument 'newValue' was never used, but the property was accessed
                        carbonModifiers = modifiers.carbonFlags
                                          ^
Sources/HotKey/KeyCombo.swift:26:22: note: did you mean to use 'newValue' instead of accessing the property's current value?
                        carbonModifiers = modifiers.carbonFlags
                                          ^~~~~~~~~
                                          newValue

@wlisac
Copy link

wlisac commented Feb 18, 2020 •
edited
Loading

I'm seeing the same warning. Would love to see this make it in.

@puliaiev
Copy link

puliaiev commented Apr 21, 2023

I was about to create a PR and found yours 😁.

@soffes soffes merged commit 581114d into soffes:master Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@msanders @wlisac @puliaiev @soffes