Fix NPE in RouterChain.java#1049
Merged
EvenLjj merged 3 commits intosofastack:masterfrom Oct 20, 2021
Merged
Conversation
|
Hi @containerAnalyzer, Please sign Contributor License Agreement! After you signed CLA, we will automatically sync the status of this pull request in 3 minutes. |
Contributor
|
Bug fix needs a test case to indicate the bug is fixed. @containerAnalyzer |
Contributor
Author
|
Here is the test case |
Codecov Report
@@ Coverage Diff @@
## master #1049 +/- ##
============================================
+ Coverage 68.84% 69.05% +0.21%
- Complexity 820 831 +11
============================================
Files 407 409 +2
Lines 17619 17723 +104
Branches 2728 2750 +22
============================================
+ Hits 12130 12239 +109
+ Misses 4085 4068 -17
- Partials 1404 1416 +12
Continue to review full report at Codecov.
|
Contributor
|
@containerAnalyzer please sign http://cla.sofastack.tech/ |
Member
Could you add test cases to codebase? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is the PR for the issue 1048