Conversation
Replace inline form panel with WordPress Modal component for add and edit configuration flows. Modal provides overlay, focus trap, title bar, and close button out of the box.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the AI Router plugin to version 0.4.1, focusing on improving the user experience when adding or editing configurations. The main enhancement is that the configuration form now opens in a WordPress Modal dialog instead of being rendered inline. This change is reflected in both the plugin code and the documentation. There are also supporting updates to version numbers and test mocks.
User Interface Improvements:
Modaldialog for a more modern and user-friendly experience, replacing the previous inline form rendering. (src/js/connectors.js,build/connectors.js) [1] [2]Modalcomponent to the UI imports and mocks to support the new modal dialog behavior. (src/js/connectors.js,build/connectors.js,tests/js/__mocks__/@wordpress/components.jsx,tests/js/setup.js) [1] [2] [3] [4]Documentation and Versioning:
ai-router.php,package.json, and documentation files. [1] [2] [3] [4]CHANGELOG.md,readme.txt) [1] [2] [3]Build Artifacts:
build/connectors.asset.php)Testing:
Modalcomponent, ensuring tests remain accurate and up-to-date. (tests/js/__mocks__/@wordpress/components.jsx,tests/js/setup.js) [1] [2]These changes collectively enhance the plugin's usability and maintain consistency across code, documentation, and tests.