Skip to content

fix: map COMPLETED_WITH_WARNINGS to WARNED in agent verification path#2605

Merged
m1n0 merged 1 commit intomainfrom
dtl-1587-is_warned-not-correctly-set-when-executing-contract-on-agent
Feb 26, 2026
Merged

fix: map COMPLETED_WITH_WARNINGS to WARNED in agent verification path#2605
m1n0 merged 1 commit intomainfrom
dtl-1587-is_warned-not-correctly-set-when-executing-contract-on-agent

Conversation

@m1n0
Copy link
Contributor

@m1n0 m1n0 commented Feb 26, 2026

Resolves: DTL-1587

Description

fixes incorrect mapping of scans in agent state

Checklist

  • I added a test to verify the new functionality.
  • I verified this PR does not break soda-extensions.

The  function
incorrectly grouped  with , mapping
both to . This caused  to
return False and  to return True when a contract executed on
the Soda agent had warned checks.

Split  into its own case mapping to
, consistent with the existing 1:1
mappings for COMPLETED_WITH_FAILURES→FAILED and
COMPLETED_WITH_ERRORS→ERROR.

Resolves: DTL-1587
@sonarqubecloud
Copy link

@m1n0 m1n0 requested a review from paulteehan February 26, 2026 07:48
@m1n0 m1n0 merged commit 9eca9c3 into main Feb 26, 2026
41 checks passed
@m1n0 m1n0 deleted the dtl-1587-is_warned-not-correctly-set-when-executing-contract-on-agent branch February 26, 2026 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants