Conversation
|
mivds
approved these changes
Feb 25, 2026
Contributor
mivds
left a comment
There was a problem hiding this comment.
Code change looks okay, but I think the test case needs a change
|
|
||
| assert result is not None | ||
| errors_str = result.get_errors_str() | ||
| assert errors_str is None or "sql_dialect" not in errors_str |
Contributor
There was a problem hiding this comment.
The second part of the assert here seems a little strange. Errors are allowed, as long as they are not about the sql_dialect? 🤔
Contributor
Author
There was a problem hiding this comment.
yeah, I wouldn't do this myself but it makes the test resilient, in case something more basic breaks this test won't necessarily fail, which is not a bad approach imo. I think I would like to try this approach, unless you think it's a blocker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please provide a description of your changes:
Fixes contract test where it would crash if reference check was present
fully vibe-coded
Checklist