Feat: Add percentage-based sampling for databricks#2597
Merged
Conversation
Niels-b
approved these changes
Feb 25, 2026
Contributor
Niels-b
left a comment
There was a problem hiding this comment.
PR itself looks good. Left one "big picture" comment. No need to change it now.
soda-databricks/src/soda_databricks/common/data_sources/databricks_data_source.py
Show resolved
Hide resolved
m1n0
approved these changes
Feb 25, 2026
soda-databricks/src/soda_databricks/common/data_sources/databricks_data_source.py
Show resolved
Hide resolved
83d66e0 to
2a9da32
Compare
Add TABLESAMPLE (pct PERCENT) support to DatabricksSqlDialect, following the same pattern as the Postgres BERNOULLI implementation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
f92eea6 to
1bbfb60
Compare
for more information, see https://pre-commit.ci
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TABLESAMPLE (pct PERCENT)support toDatabricksSqlDialectfor percentage-based samplingTABLESAMPLE BERNOULLIimplementationTest plan
uv run pytest soda-databricks/tests/unit/test_databricks_dialect.pyTEST_DATASOURCE=databricks🤖 Generated with Claude Code