Feat: Add percentage-based sampling for postgres#2596
Merged
Conversation
38c3bde to
0138df0
Compare
Niels-b
approved these changes
Feb 25, 2026
Contributor
Niels-b
left a comment
There was a problem hiding this comment.
Nice work on the new testing methodology. LGTM!
m1n0
approved these changes
Feb 25, 2026
Contributor
m1n0
left a comment
There was a problem hiding this comment.
Nice work on the separation+testing!
soda-postgres/src/soda_postgres/common/data_sources/postgres_data_source.py
Outdated
Show resolved
Hide resolved
soda-postgres/src/soda_postgres/common/data_sources/postgres_data_source.py
Show resolved
Hide resolved
c28f4a1 to
83d66e0
Compare
83d66e0 to
2a9da32
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds percentage-based sampling support to postgres.
soda-postgres/tests/unit/test_postgres_dialect.py. No data source required.supports_samplermethod in the dialect that we can use to check if sampling is supported, and fall back to less optimized flows if not.Checklist