Merged
Conversation
312a95a to
6eae2d5
Compare
6eae2d5 to
7511896
Compare
|
mivds
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Please provide a description of your changes:
fabric_data_source.py— Three changes to the Fabric data source:Optional[DataSourceConnection]parameter toFabricDataSourceImpl.__init__to match the parent signatureis_same_soda_data_type_with_synonymsto FabricSqlDialect — treatsTIMESTAMPandVARCHARas equivalent because the Fabric cursor doesn't distinguish between varchar and datetime2 on empty query results.encode_string_for_sqlcall in_build_insert_into_values_row_sqlto fix an issue with newlines.fabric_data_source_test_helper.py:drop_schema_if_existsnow drops all views and tables in a schema before dropping the schema itself, since SQL Server/Fabric doesn't supportCASCADEChecklist