Skip to content

Fix: Update Fabric support#2595

Merged
Niels-b merged 2 commits intomainfrom
r-472-fabric
Feb 27, 2026
Merged

Fix: Update Fabric support#2595
Niels-b merged 2 commits intomainfrom
r-472-fabric

Conversation

@Niels-b
Copy link
Contributor

@Niels-b Niels-b commented Feb 24, 2026

Description

Please provide a description of your changes:
fabric_data_source.py — Three changes to the Fabric data source:

  1. Added an Optional[DataSourceConnection] parameter to FabricDataSourceImpl.__init__ to match the parent signature
  2. Added is_same_soda_data_type_with_synonyms to FabricSqlDialect — treats TIMESTAMP and VARCHAR as equivalent because the Fabric cursor doesn't distinguish between varchar and datetime2 on empty query results.
  3. Removed an encode_string_for_sql call in _build_insert_into_values_row_sql to fix an issue with newlines.

fabric_data_source_test_helper.py: drop_schema_if_exists now drops all views and tables in a schema before dropping the schema itself, since SQL Server/Fabric doesn't support CASCADE

Checklist

@Niels-b Niels-b force-pushed the r-472-fabric branch 2 times, most recently from 312a95a to 6eae2d5 Compare February 25, 2026 13:10
@sonarqubecloud
Copy link

@Niels-b Niels-b requested review from m1n0, mivds and paulteehan February 26, 2026 16:03
@Niels-b Niels-b marked this pull request as ready for review February 26, 2026 16:03
@Niels-b Niels-b changed the title R 472 fabric Fix: Update Fabric support Feb 26, 2026
@Niels-b Niels-b merged commit aa2eb9e into main Feb 27, 2026
78 of 79 checks passed
@Niels-b Niels-b deleted the r-472-fabric branch February 27, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants