Skip to content

Fix: potential issue with types not being converted to str in QueryResult#2590

Merged
Niels-b merged 5 commits intomainfrom
r-470-oracle
Feb 23, 2026
Merged

Fix: potential issue with types not being converted to str in QueryResult#2590
Niels-b merged 5 commits intomainfrom
r-470-oracle

Conversation

@Niels-b
Copy link
Contributor

@Niels-b Niels-b commented Feb 18, 2026

Description

Please provide a description of your changes:

  • What problem are you solving?
    • A potential issue whereby the QueryResult will crash on the tabulate function if it cannot cast the type retrieved from the DB to a str.
  • Any expected impact on downstream packages/services?
    • No
  • Reference issue # if available.

Checklist

  • I added a test to verify the new functionality.
    • There is an indirect test for this in soda-extensions; testing an unknown data type for Oracle.
  • I verified this PR does not break soda-extensions.

@Niels-b Niels-b requested review from m1n0, mivds and paulteehan February 20, 2026 16:11
@Niels-b Niels-b marked this pull request as ready for review February 20, 2026 16:12
Copy link
Contributor

@paulteehan paulteehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@mivds mivds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just questioning if we shouldn't widen it even more

@sonarqubecloud
Copy link

@Niels-b Niels-b merged commit 03fc516 into main Feb 23, 2026
41 checks passed
@Niels-b Niels-b deleted the r-470-oracle branch February 23, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants