Skip to content

Feat! Update to psycopg3. Updates to Databricks data types#2558

Merged
Niels-b merged 9 commits intomainfrom
r-516-add-more-tests-for-dwh-cross-data-source-support
Feb 4, 2026
Merged

Feat! Update to psycopg3. Updates to Databricks data types#2558
Niels-b merged 9 commits intomainfrom
r-516-add-more-tests-for-dwh-cross-data-source-support

Conversation

@Niels-b
Copy link
Contributor

@Niels-b Niels-b commented Feb 2, 2026 •
edited
Loading

Description

Please provide a description of your changes:

  • What problem are you solving?
    • Supporting changes for DWH: Databricks data type mappings.
      • Enabled numeric scale/precision
      • Fixed issue with timestamp mappings when creating a data type
    • Update to psycopg3 for Postgres connector
  • Any expected impact on downstream packages/services?
    • No
  • Reference issue # if available.

Checklist

  • I added a test to verify the new functionality.
    • This is tested implicitly already
  • I verified this PR does not break soda-extensions.

@Niels-b Niels-b marked this pull request as ready for review February 3, 2026 10:03
@Niels-b Niels-b requested review from m1n0, mivds and paulteehan February 3, 2026 10:04
mivds
mivds approved these changes Feb 3, 2026
View reviewed changes
Copy link
Contributor

@mivds mivds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few comments to review.

Regarding naming/versioning:

  • If we want to follow conventional commits, this PR should be prefixed as Feat! since it's a breaking change
    • Probably best to split in separate PR's for future. It's two different features (postgres upgrade + databricks data type improvements) bunched together, which will complicate release notes once they are automated
  • Will we release this as a minor version bump? I.e. 4.0.x -> 4.1.0?

@Niels-b Niels-b changed the title Update to psycopg3. Updates to Databricks data types Feat! Update to psycopg3. Updates to Databricks data types Feb 3, 2026
@Niels-b
Copy link
Contributor Author

Niels-b commented Feb 3, 2026

Thanks for the review and the comment!
I will update the title. Indeed, in the future best to split this up into multiple PRs.

Version wise; no strong opinion on this. I think 4.0.x is still okay 🤔 ?

@mivds
Copy link
Contributor

mivds commented Feb 4, 2026

Version wise; no strong opinion on this. I think 4.0.x is still okay 🤔 ?

Probably, yes. I was mostly asking because we're moving from psycopg2 to psycopg3. That's a big shift in the soda-postgres package. It should be largely internal though, unless users directly interact with psycopg2

@Niels-b
Copy link
Contributor Author

Niels-b commented Feb 4, 2026

I think this is all right. It's mainly the package that is changing. Most of the things are backwards compatible (for us at least); all tests passed without issues.
Indeed, only when users use specific psycopg2 features/api will this be breaking for them.
So I'm inclined to go for 4.0.x.

@Niels-b Niels-b force-pushed the r-516-add-more-tests-for-dwh-cross-data-source-support branch from bf97e2a to a693273 Compare February 4, 2026 15:33
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 4, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Niels-b Niels-b merged commit c1a2007 into main Feb 4, 2026
38 checks passed
@Niels-b Niels-b deleted the r-516-add-more-tests-for-dwh-cross-data-source-support branch February 4, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mivds mivds mivds approved these changes

@m1n0 m1n0 Awaiting requested review from m1n0

@paulteehan paulteehan Awaiting requested review from paulteehan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Niels-b @mivds