Skip to content

feat(snowflake): add oauth support#2415

Merged
adkinsty merged 1 commit intomainfrom
snowflake-v3-add-oauth-support
Sep 23, 2025
Merged

feat(snowflake): add oauth support#2415
adkinsty merged 1 commit intomainfrom
snowflake-v3-add-oauth-support

Conversation

@adkinsty
Copy link
Collaborator

@adkinsty adkinsty commented Sep 22, 2025 •
edited
Loading

Updated the snowflake data source connector so it supports OAuth 2.0 Client Credentials, e.g.:

data_source my_datasource_name:
  type: snowflake
  account: ${SNOWFLAKE_ACCOUNT}
  database: <database>
  schema: <schema>
  warehouse: <warehouse>
  role: <role>
  connection_timeout: 240
  client_session_keep_alive: false
  authenticator: OAUTH_CLIENT_CREDENTIALS
  oauth_client_id: <client-id>
  oauth_client_secret: <client-secret>
  oauth_token_request_url: https://<idp>/oauth/token
  oauth_scope: "scope1 scope2"        # space-delimited; optional if derived by role

This change was requested by a v3 soda-core user in slack here. Since we support Oauth in v3 soda-library and v4 soda-core, @m1n0 agreed it would be ok to add Oauth to v3 soda-core to unblock this user.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 22, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

milanaleksic
milanaleksic approved these changes Sep 23, 2025
View reviewed changes
Copy link
Contributor

@milanaleksic milanaleksic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this aligns with the other approaches (in library and core v4) I think this makes total sense

@adkinsty
Copy link
Collaborator Author

adkinsty commented Sep 23, 2025

I shared this code with the community user and they notified me that Oauth is working now.

@adkinsty
Copy link
Collaborator Author

adkinsty commented Sep 23, 2025

If this aligns with the other approaches (in library and core v4) I think this makes total sense

yes I copied and pasted the code directly from v3 soda-library

@adkinsty adkinsty merged commit 1d2315b into main Sep 23, 2025
15 checks passed
@adkinsty adkinsty deleted the snowflake-v3-add-oauth-support branch September 23, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@milanaleksic milanaleksic milanaleksic approved these changes

@m1n0 m1n0 Awaiting requested review from m1n0

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adkinsty @milanaleksic