Skip to content

hazelcast version updates#25

Merged
NeatGuyCoding merged 2 commits intomainfrom
hazelcast-version
Nov 20, 2025
Merged

hazelcast version updates#25
NeatGuyCoding merged 2 commits intomainfrom
hazelcast-version

Conversation

@sanjomo
Copy link
Member

@sanjomo sanjomo commented Nov 20, 2025 •
edited by coderabbitai bot
Loading

pom xml refactoring

Summary by CodeRabbit

  • Chores
    • Updated core dependency for Hazelcast to a newer, supported version and aligned dependency coordinates.
    • Removed explicit version in one module to rely on centralized version management.
    • License reference migrated to HTTPS for improved security.
    • Project maintainer information updated (added new maintainer entry).

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 20, 2025 •
edited
Loading

Walkthrough

Updated project POMs: license URL changed to HTTPS, a new developer entry added, Hazelcast property bumped to 5.2.0 and artifactId changed from hazelcast-client to hazelcast, and the module-level explicit Hazelcast version was removed to rely on parent dependency management.

Changes

Cohort / File(s) Summary
Hazelcast version & artifact changes
pom.xml, netty-socketio-core/pom.xml		 <hazelcast.version> updated to 5.2.0 in pom.xml; DependencyManagement artifactId changed from hazelcast-client to hazelcast; module netty-socketio-core/pom.xml removed explicit Hazelcast <version> element to use parent-managed version.
Project metadata
pom.xml		 License <url> switched from http://... to https://...; new <developer> added with id sanjomo, name Santhosh Mohan, roles include Maintainer and Developer.

Sequence Diagram(s)

(omitted — changes are build metadata only; no control-flow modifications to visualize)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20–30 minutes

  • Verify compatibility with Hazelcast 5.2.0 vs previous 3.x APIs and client/server expectations.
  • Confirm all references to hazelcast-client are intentionally replaced or no longer required.
  • Ensure parent POM dependency management supplies the intended Hazelcast version for all modules.
  • Check build and CI for any dependency resolution or runtime test failures.

Poem

🐰 I hopped through poms with whiskers bright,
Swapped client for core and set version right.
HTTPS shining, a new friend on the way—
Hazelcast upgraded, I twirl and play! 🎩

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description is too vague and lacks required sections. It only contains a generic phrase 'pom xml refactoring' without following the provided template structure. Expand the description to include all required template sections: Type of Change, Changes Made, Testing, Checklist, and Related Issue. Provide specific details about the Hazelcast upgrade and other changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: updating Hazelcast from version 3.12.12 to 5.2.0, which is the primary objective of this pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hazelcast-version
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 45f245c and 3e2fa69.

📒 Files selected for processing (1)
  • pom.xml (4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: build (17) / build
  • GitHub Check: build (25) / build
  • GitHub Check: build (21) / build
  • GitHub Check: Analyze (java-kotlin)
  • GitHub Check: Analyze (java-kotlin)
🔇 Additional comments (4)
pom.xml (4)

31-31: License URL secured with HTTPS.

Good hygiene update; no functional impact.

54-61: Developer metadata added.

Standard project metadata entry; no functional impact.

310-315: Artifact ID change verified as correct and consistent.

Verification confirms the hazelcast artifact change is properly implemented:

  • Parent pom.xml defines hazelcast version 5.2.0 in dependencyManagement
  • Child module (netty-socketio-core) correctly inherits the version without explicit override
  • No references to deprecated hazelcast-client exist anywhere in the codebase
  • All modules properly use scope:provided as intended

87-87: Code is compatible with Hazelcast 5.2.0; no changes needed.

Hazelcast 5.2.0 supports the HazelcastClient.newHazelcastClient(clientConfig) API pattern, and the ClientConfig class remains in the com.hazelcast.client.config package. Minor version releases include backward-compatible functionality and bug fixes, so the existing imports of com.hazelcast.client.HazelcastClient, com.hazelcast.client.config.ClientConfig, and com.hazelcast.core.HazelcastInstance are fully supported. The codebase requires no modifications to compile and run against 5.2.0.

Likely an incorrect or invalid review comment.

Comment @coderabbitai help to get the list of available commands and usage tips.

@sanjomo
reduce hazelcast to 5.2.0
3e2fa69 
5.2+ versions have java 11+ or 17+ requirement , so downgrading it to 5.2, whoever needs they can change it as all 5.x minor versions are api compatible
@sanjomo
Copy link
Member Author

sanjomo commented Nov 20, 2025

@NeatGuyCoding 5.2+ versions have java 11+ or 17+ requirement , so downgrading it to 5.2, whoever needs they can change it to any 5.x version as all the 5.x minor versions are api compatible

@sanjomo sanjomo self-assigned this Nov 20, 2025
@NeatGuyCoding NeatGuyCoding merged commit 0423b81 into main Nov 20, 2025
8 checks passed
@NeatGuyCoding NeatGuyCoding deleted the hazelcast-version branch November 20, 2025 23:30
@NeatGuyCoding NeatGuyCoding mentioned this pull request Nov 21, 2025
Merged
@sanjomo sanjomo restored the hazelcast-version branch November 22, 2025 04:53
@sanjomo sanjomo deleted the hazelcast-version branch December 14, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NeatGuyCoding NeatGuyCoding NeatGuyCoding approved these changes

Assignees

@sanjomo sanjomo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sanjomo @NeatGuyCoding