You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the collectData() function, the field cliBaseDownloadURL now uses the element's placeholder as a fallback if the value is empty. This prevents users from clearing the setting (e.g., to revert to an environment-controlled default or to unset a custom URL). When a user deletes the input and blurs the field, the hardcoded placeholder string is saved to preferences instead of an empty string. The cross-file context HTMLSettingsPreferencePage.java shows that this value is persisted directly; thus, the UI will permanently show the 'default' string as a hardcoded value on subsequent reloads even if the user intended to leave it empty.
The repositionTooltip function attempts to measure the popup's dimensions and position using getBoundingClientRect() on line 394 while the element is still display: none (per the CSS on line 229). In standard browser engines, including the WebKit/WebView2 engines used by Eclipse, calling this method on a hidden element returns zero for all properties. Consequently, the overflow checks for rect.top, rect.right, and rect.left will always evaluate to false, making the viewport-aware repositioning logic effectively a no-op.
var rect = popup.getBoundingClientRect();
📚 Repository Context Analyzed
This review considered 26 relevant code sections from 11 files (average relevance: 0.66)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!