Skip to content

fix: update settings fallback html styling [IDE-1926]#379

Merged
ShawkyZ merged 1 commit intomainfrom
fix/IDE-1926_update-settings-fallback-html-styling
Apr 13, 2026
Merged

fix: update settings fallback html styling [IDE-1926]#379
ShawkyZ merged 1 commit intomainfrom
fix/IDE-1926_update-settings-fallback-html-styling

Conversation

@andrewrobinsonhodges-snyk
Copy link
Copy Markdown
Contributor

Description

Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.

Checklist

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@snyk-io
Copy link
Copy Markdown

snyk-io bot commented Apr 10, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@snyk-pr-review-bot
Copy link
Copy Markdown

PR Reviewer Guide 🔍

🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Configuration Clearing Prevented 🟠 [major]

In the collectData() function, the field cliBaseDownloadURL now uses the element's placeholder as a fallback if the value is empty. This prevents users from clearing the setting (e.g., to revert to an environment-controlled default or to unset a custom URL). When a user deletes the input and blurs the field, the hardcoded placeholder string is saved to preferences instead of an empty string. The cross-file context HTMLSettingsPreferencePage.java shows that this value is persisted directly; thus, the UI will permanently show the 'default' string as a hardcoded value on subsequent reloads even if the user intended to leave it empty.

cliBaseDownloadURL: get('cliBaseDownloadURL').value || get('cliBaseDownloadURL').placeholder,
Broken Tooltip Positioning 🟡 [minor]

The repositionTooltip function attempts to measure the popup's dimensions and position using getBoundingClientRect() on line 394 while the element is still display: none (per the CSS on line 229). In standard browser engines, including the WebKit/WebView2 engines used by Eclipse, calling this method on a hidden element returns zero for all properties. Consequently, the overflow checks for rect.top, rect.right, and rect.left will always evaluate to false, making the viewport-aware repositioning logic effectively a no-op.

var rect = popup.getBoundingClientRect();
📚 Repository Context Analyzed

This review considered 26 relevant code sections from 11 files (average relevance: 0.66)

@ShawkyZ ShawkyZ merged commit bf8e0cc into main Apr 13, 2026
10 checks passed
@ShawkyZ ShawkyZ deleted the fix/IDE-1926_update-settings-fallback-html-styling branch April 13, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants