feat: enhance HTML settings page with full IDE configuration support [IDE-1625]#348
Merged
nick-y-snyk merged 7 commits intomainfrom Jan 9, 2026
Merged
feat: enhance HTML settings page with full IDE configuration support [IDE-1625]#348nick-y-snyk merged 7 commits intomainfrom
nick-y-snyk merged 7 commits intomainfrom
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
| @Override | ||
| public void dispose() { | ||
| if (instance == this) { | ||
| instance = null; |
Check warning
Code scanning / PMD
Assigning an Object to null is a code smell. Consider refactoring. Warning
- Add comprehensive IdeConfigData class with typed nested structures for all settings - Implement retry logic (2 attempts, 2s delay) for loading LS HTML before fallback - Add FolderConfig support with additionalEnv, additionalParameters, and scanCommandConfig - Implement auth token notification to HTML page after successful authentication - Fix UI hang by making updateConfiguration async in performOk - Fix 10s timeout by checking LS connection before executeCommand in getConfigHtml - Improve button styling with proper colors and contrast in BaseHtmlProvider - Add static instance tracking for auth token callback from hasAuthenticated event
14e28fd to
f5115e3
Compare
- Extract duplicate string literal "#FFFFFF" to constant in BaseHtmlProvider - Mark static instance field as volatile for thread safety in HTMLSettingsPreferencePage - Extract loop logic into helper methods to avoid object instantiation in loops - Replace reference equality (==) with equals() for object comparison - Isolate null assignment in dedicated clearInstance() method
| if (commandService != null) { | ||
| // Refresh severity filter commands | ||
| commandService.refreshElements( | ||
| "io.snyk.eclipse.plugin.commands.snykFilterCritical", null); |
Contributor
There was a problem hiding this comment.
I wonder if we can use constants here that are synchronized with the plugin.xml definition, so we have compile-time validation and consistency.
Contributor
There was a problem hiding this comment.
was there any resolution to this?
Contributor
There was a problem hiding this comment.
... and what is the resolution? please expand and point me to the solution.
- Replace fully qualified class name with import for HTMLSettingsPreferencePage - Replace hardcoded command ID strings with constants from IHandlerCommands - Fix theme constant usage: use proper Eclipse workbench colors instead of hyperlink colors for buttons - Convert IdeConfigData and inner classes to Java records (eliminates ~300 lines of boilerplate) - Remove unnecessary clearInstance() method in HTMLSettingsPreferencePage - Add synchronization to prevent race conditions between login and logout operations
Comment on lines
+332
to
+336
| new ScanCommandConfig( | ||
| configData.preScanCommand(), | ||
| Boolean.TRUE.equals(configData.preScanOnlyReferenceFolder()), | ||
| configData.postScanCommand(), | ||
| Boolean.TRUE.equals(configData.postScanOnlyReferenceFolder())); |
Check warning
Code scanning / PMD
Avoid instantiating new objects inside loops Warning
f063812 to
934be4b
Compare
bastiandoetsch
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Button Styling (BaseHtmlProvider.java)
Settings Page Refactor (HTMLSettingsPreferencePage.java)
Test plan