feat: add riskScoreThreshold support to settings#346
Merged
bastiandoetsch merged 2 commits intomainfrom Dec 18, 2025
Merged
Conversation
Add riskScoreThreshold field to enable filtering issues by risk score. This fixes the same issue that was identified in the IntelliJ plugin where the riskScoreThreshold value was being lost. Changes: - Add RISK_SCORE_THRESHOLD constant to Preferences.java - Add riskScoreThreshold field to Settings.java - Update LsConfigurationUpdater to read and include riskScoreThreshold - Handle riskScoreThreshold in HTMLSettingsPreferencePage.parseAndSaveConfig() - Add tests for riskScoreThreshold handling
|
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Comment on lines
+75
to
+77
| } catch (NumberFormatException e) { | ||
| // ignore, keep null | ||
| } |
Check warning
Code scanning / PMD
Avoid empty catch blocks Warning
rrama
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
riskScoreThresholdfield to enable filtering issues by risk score. This fixes the same issue that was identified in the IntelliJ plugin where theriskScoreThresholdvalue was being lost.Root Cause
The
riskScoreThresholdfield was completely missing from the Eclipse plugin:Preferences.javaRISK_SCORE_THRESHOLDconstantSettings.javariskScoreThresholdfieldLsConfigurationUpdater.javagetCurrentSettings()HTMLSettingsPreferencePage.javaparseAndSaveConfig()Changes
RISK_SCORE_THRESHOLDconstant toPreferences.javariskScoreThresholdfield toSettings.javaLsConfigurationUpdaterto read and includeriskScoreThresholdriskScoreThresholdinHTMLSettingsPreferencePage.parseAndSaveConfig()riskScoreThresholdhandlingData Flow (Fixed)
{riskScoreThreshold: 200}✓__saveIdeConfig__→ Eclipse receives JSON ✓HTMLSettingsPreferencePage.parseAndSaveConfig()→ stores toPreferences✓updateConfiguration()→LsConfigurationUpdater.getCurrentSettings()✓SettingsincludesriskScoreThreshold→ sent to LS ✓riskScoreThreshold✓