feat: render settings page served from language server [IDE-1457]#345
Merged
andrewrobinsonhodges-snyk merged 28 commits intomainfrom Dec 16, 2025
Merged
Conversation
|
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
rrama
approved these changes
Dec 16, 2025
Contributor
rrama
left a comment
There was a problem hiding this comment.
LGTM, just have a bit of old code in there it seems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Snyk plugin Settings page now uses HTML served from Language Server by default.
This can be overridden with an environment variable; we use factories to create the correct page.
Note that Eclipse splits out the per-project properties. We have replaced that page with a link to the main settings page.
I have also removed some unused code in FolderConfig.
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!