Skip to content

chore: prepare for CCI ui FeatureFlag to always be true#337

Merged
nick-y-snyk merged 1 commit intomainfrom
IDE-1529-eclipse
Nov 7, 2025
Merged

chore: prepare for CCI ui FeatureFlag to always be true#337
nick-y-snyk merged 1 commit intomainfrom
IDE-1529-eclipse

Conversation

@nick-y-snyk
Copy link
Copy Markdown
Contributor

Description

Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.

Checklist

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@nick-y-snyk nick-y-snyk requested review from a team as code owners November 5, 2025 22:12
@snyk-io
Copy link
Copy Markdown

snyk-io bot commented Nov 5, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

}
}

@SuppressWarnings("PMD.AvoidCatchingGenericException")

Check warning

Code scanning / PMD

The String literal "PMD.AvoidCatchingGenericException" appears 6 times in this file; the first occurrence is on line 196

The String literal "PMD.AvoidCatchingGenericException" appears 6 times in this file; the first occurrence is on line 196
Copy link
Copy Markdown
Contributor

@rrama rrama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

if (totalIssueCount == 0) {
return CONGRATS_NO_ISSUES_FOUND;
} else {
if (ignoredIssueCount == 0) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit pick: could be an else if to be consistent with IntelliJ.

@nick-y-snyk nick-y-snyk merged commit 0478940 into main Nov 7, 2025
8 checks passed
@nick-y-snyk nick-y-snyk deleted the IDE-1529-eclipse branch November 7, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants