fix: resolve handle leak in image descriptor handling [IDE-1421]#323
Merged
bastiandoetsch merged 4 commits intomainfrom Aug 18, 2025
Merged
fix: resolve handle leak in image descriptor handling [IDE-1421]#323bastiandoetsch merged 4 commits intomainfrom
bastiandoetsch merged 4 commits intomainfrom
Conversation
- Replace getImageDescriptorFromImage() with direct workbench registry access - Fix handle leak caused by getImageData() creating unreleased GC handles - Add comprehensive tests for TreeLabelProvider image caching and disposal - Improve thread safety in TreeLabelProvider with proper synchronization - Add tests to verify no handle leaks in BaseTreeNode The fix eliminates the SWTError: No more handles error by avoiding the creation of GC handles entirely and getting ImageDescriptors directly from Eclipse's workbench registry instead of converting from Images.
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
| public FileTreeNode(String value) { | ||
| super(value); | ||
| this.setPath(Paths.get(value)); | ||
| this.setPath(Paths.get(value)); //NOPMD |
Check warning
Code scanning / PMD
Unnecessary PMD suppression comment
a4f7f4a to
bdef528
Compare
acke
reviewed
Aug 18, 2025
acke
reviewed
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The fix eliminates the SWTError: No more handles error by avoiding the creation of GC handles entirely and getting ImageDescriptors directly from Eclipse's workbench registry instead of converting from Images.
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!