Skip to content

chore: remove code quality [IDE-1176]#302

Merged
bastiandoetsch merged 8 commits intomainfrom
chore/IDE-1176_remove-snyk-code-quality
Jun 6, 2025
Merged

chore: remove code quality [IDE-1176]#302
bastiandoetsch merged 8 commits intomainfrom
chore/IDE-1176_remove-snyk-code-quality

Conversation

@bastiandoetsch
Copy link
Copy Markdown
Contributor

@bastiandoetsch bastiandoetsch commented Jun 6, 2025

Description

This pull request completely removes the "Snyk Code Quality" feature from the Snyk Eclipse plugin.

Key Changes

A total of 29 files were modified to remove the Code Quality feature, touching everything from UI components to the language server communication layer.

🧹 Feature & UI Removal

  • Preferences: Removed the "Snyk Code Quality enabled" checkbox from the main PreferencesPage.
  • Snyk Tool View:
    • Deleted the "Code Quality" node from the results tree in SnykToolView, ContentRootNode, and related classes.
    • Removed the "Enable/disable Code Quality" command and its corresponding toolbar icon from plugin.xml.
  • Commands & Handlers: Deleted EnableCodeQualityProductHandler and removed references from all other handler-related classes (IHandlerCommands, BaseHandler, EnableAllProductHandler).
  • UI Text & Labels: Updated bundle.properties and feature/category.xml to remove all user-facing strings related to "Code Quality".

🔧 Core Logic & Backend Simplification

  • Issue Caching (SnykIssueCache): The cache no longer maintains a separate collection for codeQualityIssues. The logic for splitting issues based on isSecurityType has been removed, and all code issues are now stored as codeSecurityIssues.
  • Language Server Communication:
    • LsConfigurationUpdater: No longer sends the ACTIVATE_SNYK_CODE_QUALITY setting to the Language Server.
    • SnykExtendedLanguageClient: Simplified the snykScan logic to no longer handle a separate "Code Quality" product node.
  • Constants & Domain Objects (ProductConstants): Removed all constants related to Code Quality (e.g., DISPLAYED_CODE_QUALITY, FILTERABLE_ISSUE_CODE_QUALITY).

⚙️ Build & Project Configuration

  • Build (plugin/.project): Removed the net.sourceforge.pmd.eclipse.plugin.pmdBuilder, which was previously used for code quality analysis.

🧪 Testing

  • Updated or removed numerous tests across the test suite (SnykExtendedLanguageClientTest, HtmlProviderFactoryTest, PreferencesTest, etc.) to reflect the removal of the feature and ensure the test suite passes.

How to Test

  1. Launch the Eclipse IDE with this version of the plugin.
  2. Navigate to Window > Preferences > Snyk.
  3. Verify that there is no checkbox for "Snyk Code Quality enabled".
  4. Open the Snyk View.
  5. Verify that the results tree only contains nodes for "Open Source", "Code Security", and "Infrastructure as Code". The "Code Quality" node is gone.
  6. Run a scan on a project.
  7. Verify that no Code Quality issues are displayed.

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated (automatic)
  • README.md updated, if user-facing

Screenshots / GIFs

image image

@bastiandoetsch bastiandoetsch requested a review from a team as a code owner June 6, 2025 06:15
@snyk-io
Copy link
Copy Markdown

snyk-io bot commented Jun 6, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

Comment thread plugin/src/main/java/io/snyk/eclipse/plugin/domain/ProductConstants.java Outdated
Comment thread plugin/src/main/java/io/snyk/languageserver/SnykIssueCache.java Outdated
Copy link
Copy Markdown
Contributor

@rrama rrama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few Qs and points.
You also missed:

  • plugin/src/main/java/io/snyk/languageserver/SnykIssueCache.java
  • feature/feature.xml
  • update-site/category.xml

Other than that good for approval.

@bastiandoetsch
Copy link
Copy Markdown
Contributor Author

Few Qs and points. You also missed:

  • plugin/src/main/java/io/snyk/languageserver/SnykIssueCache.java
    updated the java docs they were not wrong through ;)
  • feature/feature.xml
    updated
  • update-site/category.xml

Other than that good for approval.

@bastiandoetsch bastiandoetsch merged commit 814f9f2 into main Jun 6, 2025
8 checks passed
@bastiandoetsch bastiandoetsch deleted the chore/IDE-1176_remove-snyk-code-quality branch June 6, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants