chore: remove code quality [IDE-1176]#302
Merged
bastiandoetsch merged 8 commits intomainfrom Jun 6, 2025
Merged
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
rrama
reviewed
Jun 6, 2025
rrama
reviewed
Jun 6, 2025
rrama
reviewed
Jun 6, 2025
rrama
approved these changes
Jun 6, 2025
Contributor
rrama
left a comment
There was a problem hiding this comment.
Few Qs and points.
You also missed:
plugin/src/main/java/io/snyk/languageserver/SnykIssueCache.javafeature/feature.xmlupdate-site/category.xml
Other than that good for approval.
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request completely removes the "Snyk Code Quality" feature from the Snyk Eclipse plugin.
Key Changes
A total of 29 files were modified to remove the Code Quality feature, touching everything from UI components to the language server communication layer.
🧹 Feature & UI Removal
PreferencesPage.SnykToolView,ContentRootNode, and related classes.plugin.xml.EnableCodeQualityProductHandlerand removed references from all other handler-related classes (IHandlerCommands,BaseHandler,EnableAllProductHandler).bundle.propertiesandfeature/category.xmlto remove all user-facing strings related to "Code Quality".🔧 Core Logic & Backend Simplification
SnykIssueCache): The cache no longer maintains a separate collection forcodeQualityIssues. The logic for splitting issues based onisSecurityTypehas been removed, and all code issues are now stored ascodeSecurityIssues.LsConfigurationUpdater: No longer sends theACTIVATE_SNYK_CODE_QUALITYsetting to the Language Server.SnykExtendedLanguageClient: Simplified thesnykScanlogic to no longer handle a separate "Code Quality" product node.ProductConstants): Removed all constants related to Code Quality (e.g.,DISPLAYED_CODE_QUALITY,FILTERABLE_ISSUE_CODE_QUALITY).⚙️ Build & Project Configuration
plugin/.project): Removed thenet.sourceforge.pmd.eclipse.plugin.pmdBuilder, which was previously used for code quality analysis.🧪 Testing
SnykExtendedLanguageClientTest,HtmlProviderFactoryTest,PreferencesTest, etc.) to reflect the removal of the feature and ensure the test suite passes.How to Test
Checklist
Screenshots / GIFs