feat: added pat to preferences page#297
Merged
bastiandoetsch merged 10 commits intomainfrom Jun 2, 2025
Merged
Conversation
c640b19 to
e051972
Compare
eba8c3a to
1e1c277
Compare
82b0ba8 to
3969e3a
Compare
3969e3a to
818de2c
Compare
| import io.snyk.languageserver.protocolextension.SnykExtendedLanguageClient; | ||
|
|
||
| public class PreferencesPage extends FieldEditorPreferencePage implements IWorkbenchPreferencePage { | ||
| private static final String TRUSTING_WORKSPACE_FOLDERS = "Trusting workspace folders..."; |
Check warning
Code scanning / PMD
Avoid unused private fields such as 'TRUSTING_WORKSPACE_FOLDERS'.
063b114 to
170f896
Compare
170f896 to
1e02e00
Compare
andrewrobinsonhodges-snyk
approved these changes
May 28, 2025
Contributor
|
TODO - need to bump LS protocol version (once LS changes are in) to handle sending "pat" as an auth type. |
Contributor
It already has Protocol version 20 - so that should be fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This ticket covers enhancing the IDE plugins' settings pages to allow a user to authenticate with PATs. As a minimum, this means:
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!