fix: update font scaling logic to not use hard coded values#264
Merged
andrewrobinsonhodges-snyk merged 7 commits intomainfrom Mar 10, 2025
Merged
fix: update font scaling logic to not use hard coded values#264andrewrobinsonhodges-snyk merged 7 commits intomainfrom
andrewrobinsonhodges-snyk merged 7 commits intomainfrom
Conversation
|
|
||
| // FontRegistry uses pt sizes, not px, so we convert here, using standard web values from | ||
| // https://www.w3.org/TR/css3-values/#absolute-lengths | ||
| double pxToPtMultiplier = 72.0 / 96.0; |
Contributor
There was a problem hiding this comment.
I guess it would make sense to define this as a constant.
bastiandoetsch
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!