feat: select treenode on snyk showdocument [IDE-957]#260
Merged
Conversation
7655879 to
269c2ae
Compare
8c50017 to
0829e65
Compare
Contributor
andrewrobinsonhodges-snyk
left a comment
There was a problem hiding this comment.
Overall function/design is good, but you have added a few methods that could do with renaming for clarity, plus a couple of potential bugs with null checks and hard coded parameters.
4 tasks
feat: apply fix command [IDE-976]
andrewrobinsonhodges-snyk
approved these changes
Feb 28, 2025
Contributor
andrewrobinsonhodges-snyk
left a comment
There was a problem hiding this comment.
I agree that this looks much better. We might want to rename SnykUriDetails or add some explanatory comments later on, as this is pretty specific to this particular URI format at the moment, but it's fine for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Will select the treenode when a code lens or a code action is triggered.
Will display the issue in details view.
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!