feat: add option to choose a folder as a scan reference#259
Merged
bastiandoetsch merged 3 commits intomainfrom Feb 10, 2025
Merged
feat: add option to choose a folder as a scan reference#259bastiandoetsch merged 3 commits intomainfrom
bastiandoetsch merged 3 commits intomainfrom
Conversation
f3a6bd9 to
216308f
Compare
ShawkyZ
reviewed
Feb 10, 2025
| SnykLogger.logInfo("No valid configuration for path: " + folderPath.toString()); | ||
| FolderConfig folderConfig = new FolderConfig(path.toString(), null, new ArrayList<>(), | ||
| new ArrayList<>()); | ||
| FolderConfig folderConfig = new FolderConfig(path.toString()); |
Contributor
There was a problem hiding this comment.
do we also need to normalize the path here?
ShawkyZ
reviewed
Feb 10, 2025
| } | ||
|
|
||
| public List<String> getAdditionalParameters() { | ||
| if (additionalParameters == null) return new ArrayList<>(); |
ShawkyZ
reviewed
Feb 10, 2025
| } | ||
|
|
||
| public String getReferenceFolderPath() { | ||
| if (referenceFolderPath == null) return ""; |
ShawkyZ
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds an option to specify a reference folder for net-new scanning instead of a branch.
Checklist
Screenshots / GIFs