Merged
Conversation
andrewrobinsonhodges-snyk
approved these changes
Feb 5, 2025
Contributor
andrewrobinsonhodges-snyk
left a comment
There was a problem hiding this comment.
Happy with this overall, though there are a few inconsistencies and further optimisations - see the comments.
The only thing that needs addressing before merge is your local path in the ruleset file (plugin/.pmd) - the rest are up to you.
| public void selectionChanged(IAction action, ISelection selection) { | ||
| this.selection = selection; | ||
| } | ||
| IWorkbenchPart part; |
Contributor
There was a problem hiding this comment.
Inconsistent indentation compared to the file above. Which is correct?
Contributor
There was a problem hiding this comment.
We should be able to automatically generate it from our "master" XML file in the root. But that's something for a different PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR solves a number of lint errors.
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!