Skip to content

feat: summary panel [IDE-892]#253

Merged
acke merged 20 commits intomainfrom
feat/IDE-892_summary-panel
Jan 30, 2025
Merged

feat: summary panel [IDE-892]#253
acke merged 20 commits intomainfrom
feat/IDE-892_summary-panel

Conversation

@acke
Copy link
Copy Markdown
Contributor

@acke acke commented Jan 18, 2025

Description

Done:

  • New Summary Panel.
  • Notification listener $/snyk.scanSummary that receives HTML as a string from Snyk Language Server, and applies it to the summary panal.
  • functions for changing tabs, toggling between all issues and delta issues.
  • Apply styling to the HTML from Snyk Language Server.
  • Hook up new browser function to the HTML tabs from Snyk Language Server.
    new BrowserFunction(browser, "enableDelta")
  • Delta base branch selection.
  • Update the getSummaryInitHtml().
  • Update styling for the HTML in the Summary Panel.

image

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@acke acke changed the title Feat/ide 892 summary panel feat: summary panel [IDE-892] Jan 18, 2025
@acke acke force-pushed the feat/IDE-892_summary-panel branch 2 times, most recently from 1652fd3 to 2d196bc Compare January 20, 2025 13:14
@acke acke marked this pull request as ready for review January 28, 2025 11:30
@acke acke requested a review from a team as a code owner January 28, 2025 11:30
@ShawkyZ
Copy link
Copy Markdown
Contributor

ShawkyZ commented Jan 28, 2025

Background color is a bit off

Comment thread plugin/src/main/java/io/snyk/eclipse/plugin/html/StaticPageHtmlProvider.java Outdated
Comment thread plugin/src/main/java/io/snyk/eclipse/plugin/html/StaticPageHtmlProvider.java Outdated
Comment thread plugin/src/main/java/io/snyk/eclipse/plugin/html/StaticPageHtmlProvider.java Outdated
Comment thread plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/SnykToolView.java Outdated
Comment thread plugin/src/main/java/io/snyk/languageserver/LsConstants.java Fixed
Comment thread plugin/src/main/java/io/snyk/languageserver/LsConstants.java Fixed
@acke acke removed the DO NOT MERGE label Jan 30, 2025
@acke acke force-pushed the feat/IDE-892_summary-panel branch from 97d40cc to 44420b6 Compare January 30, 2025 10:26
@acke acke force-pushed the feat/IDE-892_summary-panel branch from adede5c to 5b278e8 Compare January 30, 2025 14:20
@acke acke force-pushed the feat/IDE-892_summary-panel branch from dd93824 to fff3029 Compare January 30, 2025 15:03
SnykIssueCache issueCache) {
private void populateFileAndIssueNodes(ProductTreeNode productTreeNode, SnykIssueCache issueCache) {
var cacheHashMap = issueCache.getCacheByDisplayProduct(productTreeNode.getProduct());
ArrayList<Issue> issuesList = new ArrayList<>(); // Reusable ArrayList

Check warning

Code scanning / PMD

Avoid using implementation types like 'ArrayList'; use the interface instead

Avoid using implementation types like 'ArrayList'; use the interface instead
@acke acke force-pushed the feat/IDE-892_summary-panel branch from 92102ca to 864ad64 Compare January 30, 2025 15:35
@acke acke force-pushed the feat/IDE-892_summary-panel branch from 864ad64 to 2147d0b Compare January 30, 2025 15:47
@acke acke merged commit 440de46 into main Jan 30, 2025
@acke acke deleted the feat/IDE-892_summary-panel branch January 30, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants