Fix takeAllTreesContent to only consume a single tag/tree.#98
Fix takeAllTreesContent to only consume a single tag/tree.#98k0ral merged 3 commits intosnoyberg:masterfrom
takeAllTreesContent to only consume a single tag/tree.#98Conversation
The documentation of `takeAllTreesContent` implies it consumes only a single tag/tree, however it's implementation currently consumes every single event remaining in the stream. Fixes snoyberg#97.
|
The documentation is indeed misleading:
I'm completely in favor of this change, but as is it looks incorrect to me: the recursive calls to |
|
Yes, see my comments on the issue. This requires some form of |
|
One of these days I will learn to not push until I'm done testing... |
…f `many_` to be changed to work.
|
ok, this is roughly how I don't know if there's a way to work around this restriction (I'm not too familiar with Conduit). Alternatively, maybe we should implement the more general version and export I'll leave you (@k0ral) to think on that, 'cause it's now bedtime for me. |
|
Considering that all exported parsers are |
The documentation of
takeAllTreesContentimplies it consumes only a singletag/tree, however it's implementation currently consumes every single event
remaining in the stream.
Fixes #97.