lowercase app name when generating postgres db name#88
Conversation
|
@tolysz I left T.toLower instead of lowering the char in the filter both because of readability and because it seems that Text.toLower handle more cases than map Char.toLower Still not sure it is the way to go, and anyway, build fails so more is to be done anyway. |
|
Since you're only dealing with ASCII letters (A-Z), there shouldn't be any difference in behavior. I don't have an opinion on which form looks nicer TBH. |
|
Can I ask you to ping me when you think this is ready to be merged? I'm taking from your comment that you still are going to make a few changes. |
|
Sure, but we already have only |
8b6393d to
77a9198
Compare
|
@tolysz that's why I then switched in my second PR to Anyway, in this third version, I did what you wanted - code is now: @snoyberg it can me berged (build is passing except on 7.4 because iproute-1.4.0 dependency failed to install) |
|
Beautiful :) |
|
Thanks! |
|
Should this same change of lowercasing the app name be applied to the scaffolding, specifically this part" https://github.com/yesodweb/yesod-scaffold/blob/df45cb46ff4c7c1dd9b41ad30ea847f6fef9d4c8/config/settings.yml#L25 |
|
Yeah, that makes sense. I'll make that change, there's something slightly (though not significantly) tricky that needs to happen there. |
|
Hi, |
|
Scratch that, @tolysz's right I think, mixed case seems to be just fine. |
Lowercase appname when generating db name in postgres plugin
Branch made from issue #86
supersede pr #87
also applied Hlint suggestion
do