Fix 502 crash when sent malformed X-Forwarded-For header#315
Merged
jezen merged 2 commits intosnoyberg:masterfrom Aug 12, 2025
Merged
Fix 502 crash when sent malformed X-Forwarded-For header#315jezen merged 2 commits intosnoyberg:masterfrom
X-Forwarded-For header#315jezen merged 2 commits intosnoyberg:masterfrom
Conversation
This test reproduces snoyberg#312.
Collaborator
Author
|
The output of this test run contains this line, as expected. |
Collaborator
Author
|
@ulidtko FYI. |
Collaborator
Author
|
This is now building successfully. The macOS-latest builds remained queued, but I think this is an internal GitHub Actions problem, and I think this package actually builds just fine on MacOS. So, I think it's fine to merge this. |
Collaborator
|
please update changelog too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commits in this PR will first accurately reproduce, and then resolve, the issue described in #312.
This PR also cleans up the pre-commit hooks configuration since they were [disappointingly] removed.