Skip to content

Fix reloading stuck on crash-looping bundles#314

Merged
jappeace merged 3 commits intosnoyberg:masterfrom
ktak-007:bugfix-ssmirnov-crash-loop-reload-stuck-294
Jul 17, 2025
Merged

Fix reloading stuck on crash-looping bundles#314
jappeace merged 3 commits intosnoyberg:masterfrom
ktak-007:bugfix-ssmirnov-crash-loop-reload-stuck-294

Conversation

@ktak-007
Copy link
Copy Markdown
Contributor

Resolves #294

@jappeace
Copy link
Copy Markdown
Collaborator

could you please undo all refactoring and only change lines relating to the fix?
Refactoring is better in a separate PR.

@ktak-007 ktak-007 force-pushed the bugfix-ssmirnov-crash-loop-reload-stuck-294 branch from a78859f to 3df39a3 Compare July 17, 2025 22:21
@ktak-007
Copy link
Copy Markdown
Contributor Author

could you please undo all refactoring and only change lines relating to the fix? Refactoring is better in a separate PR.

Ok, I've just split this into three commits to make it easier to review.
I can't separate it into another PR because I need to share AppState between App and AppManager. Without this refactoring I get cyclical module dependency.

@jappeace jappeace merged commit 82a641b into snoyberg:master Jul 17, 2025
9 checks passed
@jappeace
Copy link
Copy Markdown
Collaborator

thanks!

@jappeace
Copy link
Copy Markdown
Collaborator

🚢
https://hackage.haskell.org/package/keter-2.1.10

@ktak-007 ktak-007 deleted the bugfix-ssmirnov-crash-loop-reload-stuck-294 branch July 18, 2025 08:04
@jezen jezen mentioned this pull request Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash-looping bundles sometimes get reloading stuck

2 participants