Resolve redundant import of Data.Monoid #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves a compiler warning about the redundant import with recent versions of base that include Monoid in Prelude.
snoyberg
approved these changes
Jan 30, 2022
Owner
snoyberg
left a comment
There was a problem hiding this comment.
Seems reasonable enough. I'll include in the next release. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves a compiler warning about the redundant import with recent
versions of base that include Monoid in Prelude.
If you don't want to add the CPP directive, we can increase the required version of
baseor just leave everything as-is and live with the warnings. Let me know what you think.