removing and then adding same tag didn't work#19
Closed
loilo wants to merge 1 commit intosniperwolf:masterfrom
loilo:patch-1
Closed
removing and then adding same tag didn't work#19loilo wants to merge 1 commit intosniperwolf:masterfrom loilo:patch-1
loilo wants to merge 1 commit intosniperwolf:masterfrom
loilo:patch-1
Conversation
removing tags only removed the related DOM element. now also iterates over the "tags" array and removes entry there since this array is used to detect duplicates. don't forget to change minified version. :)
Owner
|
Hi @loilo, thank you for this pull request. I just release the v1.3.1, where I refactored a little bit the code and enhanced the plugin with methods, that help you to work with taggingJS using JavaScript directly. I think that now is more flexible and also extensible. This version also include something that is similar to your changes. Look at |
Author
|
Nice stuff. Thought about things like that today when I used the plugin. Great plans, I'm excited to see the outcomes. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removing tags only removed the related DOM element.
now also iterates over the "tags" array and removes entry there since this array is used to detect duplicates.
don't forget to change minified version. :)