Skip to content

WIP: pass setGridStyles through#9

Merged
snide merged 1 commit intosnide:design/toolbarfrom
thompsongl:design/toolbar
Aug 15, 2019
Merged

WIP: pass setGridStyles through#9
snide merged 1 commit intosnide:design/toolbarfrom
thompsongl:design/toolbar

Conversation

@thompsongl
Copy link
Copy Markdown
Contributor

This gets you closer to what you want: components that use useStyleSelector can optionally pass it a new config when props change. useEffect watches for prop changes; the now available setGridStyles function updates the hook value(s).

You'll see, though, that odd things happen in the docs when you attempt to change styles with the different methods. This is because the full style config is getting changed each time. You'll need some kind of reconciliation step to determine what style(s) were intended to be changed, which might be tricky.

@snide snide merged commit 73bd35c into snide:design/toolbar Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants