WIP: pass setGridStyles through#9
Merged
snide merged 1 commit intosnide:design/toolbarfrom Aug 15, 2019
Merged
Conversation
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gets you closer to what you want: components that use
useStyleSelectorcan optionally pass it a new config when props change.useEffectwatches for prop changes; the now availablesetGridStylesfunction updates the hook value(s).You'll see, though, that odd things happen in the docs when you attempt to change styles with the different methods. This is because the full style config is getting changed each time. You'll need some kind of reconciliation step to determine what style(s) were intended to be changed, which might be tricky.