Skip to content

Granary is generating "quotation-of" from content in the tweet that is not a quotation #155

@aaronpk

Description

@aaronpk

This tweet is an example: https://twitter.com/oktadev/status/1018179594367782913

I'm guessing it's picking up on the fact that the tweet ends in a URL. But there is no additional information about that URL available, so the information in the quotation-of property ends up being not useful.

I think it should limit to generating the quotation-of property only if there is an actual tweet.

Twitter doesn't include the quoted tweet URL in the parent tweet text anymore either https://twittercommunity.com/t/updating-how-urls-are-rendered-in-the-quote-tweet-payload/105473

Here's the HTML Granary is generating for the tweet above:

<article class="h-entry">
  <span class="p-uid">tag:twitter.com:1018179594367782913</span>
  
  <time class="dt-published" datetime="2018-07-14T17:05:06+00:00">2018-07-14T17:05:06+00:00</time>
  
  <span class="p-author h-card">
    <data class="p-uid" value="tag:twitter.com:oktadev"></data>
<data class="p-numeric-id" value="786323471877836800"></data>
    <a class="p-name u-url" href="http://developer.okta.com">OktaDev</a>
<a class="u-url" href="https://developer.okta.com/blog"></a>
<a class="u-url" href="https://devforum.okta.com"></a>
    <span class="p-nickname">oktadev</span>
    <img class="u-photo" src="https://pbs.twimg.com/profile_images/1006555705082384384/izi1LTo4.jpg" alt="" />
  </span>

  <a class="u-url" href="https://twitter.com/oktadev/status/1018179594367782913">https://twitter.com/oktadev/status/1018179594367782913</a>
  <div class="e-content p-name">
  
  Three Developer Tools I'm Thankful For <a href="https://developer.okta.com/blog/2017/11/22/three-developer-tools-im-thankful-for">developer.okta.com/blog/2017/11/2…</a>
  </div>





<article class="u-quotation-of h-cite">
  <span class="p-uid"></span>
  
  
  

  <a class="p-name u-url" href="https://developer.okta.com/blog/2017/11/22/three-developer-tools-im-thankful-for">developer.okta.com/blog/2017/11/2…</a>
  <div class="">
  
  
  </div>

</article>

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions