Skip to content

Support for gadget snaps#886

Merged
sergiusens merged 1 commit intocanonical:masterfrom
sergiusens:feature/1638824/gadget-support
Nov 3, 2016
Merged

Support for gadget snaps#886
sergiusens merged 1 commit intocanonical:masterfrom
sergiusens:feature/1638824/gadget-support

Conversation

@sergiusens
Copy link
Contributor

LP: #1638824

Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com

LP: #1638824

Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
Copy link
Contributor

@zyga zyga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ogra1
Copy link

ogra1 commented Nov 3, 2016

it might make sense to mention the path in the error message, nothing makes clear that gadget.yaml needs to live in a meta/ subdir.

@sergiusens
Copy link
Contributor Author

@ogra1 it says clearly, "in the root of your snapcraft project"

@sergiusens sergiusens merged commit 5610f0e into canonical:master Nov 3, 2016
@sergiusens sergiusens deleted the feature/1638824/gadget-support branch November 3, 2016 13:29
kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017
LP: #1638824

Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants