lp 1768233 workaround for plainbox_provider plugin#2140
Merged
sergiusens merged 2 commits intocanonical:masterfrom May 18, 2018
Merged
lp 1768233 workaround for plainbox_provider plugin#2140sergiusens merged 2 commits intocanonical:masterfrom
sergiusens merged 2 commits intocanonical:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2140 +/- ##
==========================================
+ Coverage 91.01% 91.02% +<.01%
==========================================
Files 193 193
Lines 12181 12182 +1
Branches 1820 1820
==========================================
+ Hits 11087 11089 +2
Misses 752 752
+ Partials 342 341 -1
Continue to review full report at Codecov.
|
sergiusens
approved these changes
May 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./runtests.sh static?./runtests.sh unit?Launchpad bug 1768233 discussed a problem that was encountered when building checkbox snaps using the plainbox-provider plugin. This PR includes the workaround discussed so builds can begin working again. Integration test included for the original report.