core: a clean command should clean.#1416
Merged
sergiusens merged 4 commits intocanonical:masterfrom Jul 26, 2017
Merged
Conversation
9552cfe to
fa26406
Compare
Contributor
|
This is different from what we discussed at the sprint: Have things changed? |
Contributor
Author
|
Basically from what I read on the bug again and the feedback I got at the sprint here. |
added 3 commits
July 22, 2017 12:26
When running clean it sometimes does not clean to avoid cleaning some things you might not want to clean but that has proven to be a cumbersome user facing feature so now it would just clean everything in the path. LP: #1582469 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
14a1994 to
5427a95
Compare
come-maiz
approved these changes
Jul 25, 2017
come-maiz
left a comment
There was a problem hiding this comment.
This works for me, and it's actually the behaviour I wanted to see.
But Kyle is right, after asking our users, not everybody considered this to be the right solution. Changing the default, without offering an option to overwrite it, might make some of them unhappy.
Contributor
Author
|
Let's see how it does in the bug reporting camp @ElOpio |
kalikiana
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Aug 3, 2017
When running clean it sometimes does not clean to avoid cleaning some things you might not want to clean but that has proven to be a cumbersome user facing feature so now it would just clean everything in the path. LP: #1582469 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
kalikiana
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Sep 21, 2017
When running clean it sometimes does not clean to avoid cleaning some things you might not want to clean but that has proven to be a cumbersome user facing feature so now it would just clean everything in the path. LP: #1582469 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running clean it sometimes does not clean to avoid cleaning some things
you might not want to clean but that has proven to be a cumbersome user
facing feature so now it would just clean everything in the path.
Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com