Conversation
I had used the "simple" strategy since in release-please's docs the Python strategy required a setup.py, but it seems to work fine without. This strategy will update the version in pyproject.toml
📝 WalkthroughWalkthroughThis pull request modifies the GitHub Actions workflow for the Changes
Sequence Diagram(s)sequenceDiagram
participant Runner as GitHub Actions Runner
participant ReleaseJob as Release-Please Job
Runner->>ReleaseJob: Trigger workflow (e.g., push/release event)
ReleaseJob->>ReleaseJob: Load configuration (release-type: python)
ReleaseJob-->>Runner: Generate releases with Python-specific settings
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/release-please.yml (1)
17-18: LGTM! Clean up trailing spaces.The change to use
release-type: pythonaligns with modern Python packaging practices and is appropriate for managing versions in pyproject.toml.Remove trailing spaces on line 18.
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 18-18: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pyproject.tomlis excluded by!pyproject.toml
📒 Files selected for processing (2)
.github/workflows/release-please.yml(1 hunks)version.txt(0 hunks)
💤 Files with no reviewable changes (1)
- version.txt
🧰 Additional context used
🪛 YAMLlint (1.35.1)
.github/workflows/release-please.yml
[error] 18-18: trailing spaces
(trailing-spaces)
🔇 Additional comments (1)
.github/workflows/release-please.yml (1)
1-66: Verify version management after removing version.txt.The workflow looks good overall. Since version.txt has been removed, please verify that:
- The version is correctly specified in pyproject.toml
- Release-please can detect and update the version correctly
Let's verify the version management setup:
✅ Verification successful
🏁 Script executed:
#!/bin/bash # Description: Check version management setup # Check if version is specified in pyproject.toml echo "Checking version in pyproject.toml:" cat pyproject.toml | grep -A 1 '^\[tool\.poetry\]' # Check release-please configuration echo -e "\nChecking release-please configuration:" fd -t f "release-please-config.json|.release-please-manifest.json"Length of output: 335
Let's run an additional check to see if a version field is declared in pyproject.toml since the initial grep didn't show one.
🏁 Script executed:
#!/bin/bash # Check for a version field in pyproject.toml echo "Searching for version field in pyproject.toml:" grep -E "^\s*version\s*=" pyproject.toml || echo "No version field found."Length of output: 163
Version management is correctly configured.
- The
pyproject.tomlfile correctly specifies a version (version = "0.1.2").- The release-please action uses
release-type: python, which by default detects and updates the version inpyproject.tomlwithout requiring a separate configuration file.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 18-18: trailing spaces
(trailing-spaces)
dlaehnemann
left a comment
There was a problem hiding this comment.
Should we merge this first, and then the resulting release-please pull request?
|
|
Yes, thats what I had in mind.
Yeah it is very useful, but a bit tricky for sure. |
I had used the "simple" strategy since in release-please's docs the Python strategy required a setup.py, but it seems to work fine without. This strategy will update the version in pyproject.toml.
I've also updated the pypi trusted Github repo to point to this one.
Sorry for all the hassle with this @dlaehnemann and @johanneskoester - appreciate your patience with me! This should be it though.
Summary by CodeRabbit