ci: bump pixi version in actions#3903
Conversation
Pixi install is failing with "failed to parse pypi name mapping" errors likely due to rate limiting when 30+ jobs are kicked off nearly simultaneously
📝 WalkthroughWalkthroughBumps Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/main.yml (1)
81-82: Consider enabling cache for additional reliability improvements.The Pixi version is consistently upgraded across both jobs, which is good. However, the PR description mentions "considering using the Pixi action's
cachefeature." Enabling caching could further reduce install load and improve reliability, potentially complementing themax-parallelfix.If the "no pixi.lock" comment indicates a blocker for enabling cache, consider if adding a lock file would be beneficial for this project.
💡 Suggested change to enable cache
If a
pixi.lockfile can be added to the repository:- cache: false # no pixi.lock - locked: false + cache: true + locked: trueNote: This would require generating and committing a
pixi.lockfile first.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/main.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: tests (2, windows-2022, py313)
- GitHub Check: tests (2, ubuntu-latest, py311)
- GitHub Check: tests (2, ubuntu-latest, py312)
- GitHub Check: tests (1, ubuntu-latest, py313)
- GitHub Check: tests (2, ubuntu-latest, py313)
- GitHub Check: tests (1, windows-2022, py313)
- GitHub Check: tests (1, macos-latest, py313)
- GitHub Check: tests (1, ubuntu-latest, py311)
- GitHub Check: tests (1, ubuntu-latest, py312)
🔇 Additional comments (2)
.github/workflows/main.yml (2)
49-49: Good solution to mitigate rate limiting.Setting
max-parallel: 10effectively addresses the rate limiting issue by preventing all ~50 matrix jobs from starting simultaneously. This reduces concurrent Pixi installs from 50 to 10, which should stay well below the rate limit threshold mentioned in the PR description.Note: This will increase total CI runtime as jobs queue, but it's a reasonable trade-off for reliability.
28-28: No action needed. Pixi v0.62.2 is a compatible stable release that works withsetup-pixi@v0.9.3. The version bump is safe and includes caching-related bug fixes relevant to your CI configuration.
|
@cademirch Did you try just updating the pixi version by it self? I guess the guys at prefix may want to know about this. I have mentioned the issue on their discord.. |
Yeah good question - I'll test that |
This reverts commit 3d45380.
|
Seems like bumping the version worked by itself. If we see more failures like in my initial comment we reevaluate. |
Pixi install github action is failing with "failed to parse pypi name mapping" errors likely due to rate limiting when 30+ jobs are kicked off nearly simultaneously
I tested this fix on #3820 since the tests kept failing due to the
pixiinstall action failing. After committing this change, the actions ran successfully.In this failing run's debug logs we see:
This warning is repeated many times until finally pixi stops retrying - this is what suggested to me that some sort of rate limit was the issue.
One downside is that this does make the CI take a bit longer to run. We could consider using the
cachefeature of the pixi action. And turning up the max-parallel, or reducing the number of test-groupsQC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.