tests: fix broken tests due to breaking changes in dependencies#2988
Closed
Hugovdberg wants to merge 2 commits intosnakemake:mainfrom
Closed
tests: fix broken tests due to breaking changes in dependencies#2988Hugovdberg wants to merge 2 commits intosnakemake:mainfrom
Hugovdberg wants to merge 2 commits intosnakemake:mainfrom
Conversation
Contributor
Author
|
Also |
|
Contributor
Author
|
This requires quite some work, apparently all kinds of dependencies have changed and I don't think just hacking the test environment to some magic combination of packages is the right way to go. @johanneskoester what do you think we should do about this? |
Contributor
|
I have fixed the test instead. But thanks for pointing me to the issue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String representation of scalars changed in numpy 2 (https://numpy.org/doc/stable/release/2.0.0-notes.html#representation-of-numpy-scalars-changed), which causes tests to fail. This PR fixes the numpy version in the tests to the last pre-2.0 version for now in order for other PRs to be able to continue.
At a later stage the tests should probably be updated to work on more recent verions of numpy or contain explicit formatting.
QC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).