Replace symbolic link judgement in _IOFile.protected#29
Merged
johanneskoester merged 1 commit intosnakemake:masterfrom Oct 14, 2019
Merged
Conversation
MacOS has incorrect behavior with follow_symlinks=False see snakemake#10
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
==========================================
- Coverage 61.16% 61.14% -0.02%
==========================================
Files 55 55
Lines 11862 11862
==========================================
- Hits 7255 7253 -2
- Misses 4607 4609 +2
Continue to review full report at Codecov.
|
johanneskoester
approved these changes
Oct 14, 2019
Contributor
johanneskoester
left a comment
There was a problem hiding this comment.
Thanks for the quick and reasonable fix!
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
os.access()in MacOS has incorrect behavior withfollow_symlinks=False, so replaces yet another symbolic link judgement.os.path.islink()returns True if the file is symbolic link.https://docs.python.org/3/library/os.path.html#os.path.islink
islink()returns False in the environment which does not support symbolic link (does not raise Exception)And actually, it can treat files, not only directories.
In detail, please refer the issue #10