fix: skip unnecessary schema validation inside of remote jobs#3601
Merged
johanneskoester merged 2 commits intomainfrom May 23, 2025
Merged
fix: skip unnecessary schema validation inside of remote jobs#3601johanneskoester merged 2 commits intomainfrom
johanneskoester merged 2 commits intomainfrom
Conversation
Contributor
📝 Walkthrough""" WalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant validate
participant workflow
Caller->>validate: Call validate(workflow, ...)
validate->>workflow: Check modifier.skip_validation
alt skip_validation is true
validate-->>Caller: Return (skip validation)
else remote_exec is true
validate->>workflow: Check remote_exec
validate-->>Caller: Return (skip validation)
else
validate->>validate: Perform schema validation
validate-->>Caller: Return (validation result)
end
""" 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (34)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Contributor
|
Please format your code with black: |
johanneskoester
pushed a commit
that referenced
this pull request
May 23, 2025
🤖 I have created a release *beep* *boop* --- ## [9.5.1](v9.5.0...v9.5.1) (2025-05-23) ### Bug Fixes * format output files in job cleanup message such that their remote query is shown instead of the local copy ([#3600](#3600)) ([91cc3ef](91cc3ef)) * skip unnecessary schema validation inside of remote jobs ([#3601](#3601)) ([9129654](9129654)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kjohnsen
pushed a commit
to kjohnsen/snakemake
that referenced
this pull request
Dec 15, 2025
…ake#3601) ### QC <!-- Make sure that you can tick the boxes below. --> * [x] The PR contains a test case for the changes or the changes are already covered by an existing test case. * [x] The documentation (`docs/`) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake). <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Improved workflow execution by skipping redundant schema validation during remote job execution, ensuring smoother and faster remote runs. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
kjohnsen
pushed a commit
to kjohnsen/snakemake
that referenced
this pull request
Dec 15, 2025
🤖 I have created a release *beep* *boop* --- ## [9.5.1](snakemake/snakemake@v9.5.0...v9.5.1) (2025-05-23) ### Bug Fixes * format output files in job cleanup message such that their remote query is shown instead of the local copy ([snakemake#3600](snakemake#3600)) ([91cc3ef](snakemake@91cc3ef)) * skip unnecessary schema validation inside of remote jobs ([snakemake#3601](snakemake#3601)) ([9129654](snakemake@9129654)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
jonasfreimuth
added a commit
to TRON-Bioinformatics/snakemake
that referenced
this pull request
Jan 14, 2026
…ote jobs (snakemake#3601)" This reverts commit 9129654. Config validation can't be skipped entirely because workflows may rely on default setting during validation. See <snakemake#3614> and <snakemake#3923>.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).Summary by CodeRabbit