fix: Fix map call in report creation#3503
Merged
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughThis pull request refactors the Changes
Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (34)
🔇 Additional comments (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
johanneskoester
approved these changes
Apr 1, 2025
johanneskoester
pushed a commit
that referenced
this pull request
Apr 1, 2025
🤖 I have created a release *beep* *boop* --- ## [9.1.4](v9.1.3...v9.1.4) (2025-04-01) ### Bug Fixes * Fix map call in report creation ([#3503](#3503)) ([44754cc](44754cc)) * in the report, do not render toggle labels if there is more than one label eligible for a toggle ([#3502](#3502)) ([3be8ca9](3be8ca9)) * only inform about storage cleanup in case of --verbose mode ([#3494](#3494)) ([62bbbf5](62bbbf5)) * provide causing rule to workflow error during checkpoint handling ([#3499](#3499)) ([b4cbe5d](b4cbe5d)) * rerun-trigger regression ([#3492](#3492)) ([811742d](811742d)) ### Documentation * note about parameter inheritance when using the "use rule with" pattern ([#3500](#3500)) ([8f6a8eb](8f6a8eb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kjohnsen
pushed a commit
to kjohnsen/snakemake
that referenced
this pull request
Dec 15, 2025
This pull request includes a small change to the `src/snakemake/report/html_reporter/template/components/abstract_results.js` file. The change corrects the syntax for mapping over `data.toggleLabels.keys()` to ensure proper functionality. * Corrected the syntax for mapping over `data.toggleLabels.keys()` in the `AbstractResults` class. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Streamlined the internal process for constructing toggle labels to improve clarity without affecting the app’s behavior or user experience. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
kjohnsen
pushed a commit
to kjohnsen/snakemake
that referenced
this pull request
Dec 15, 2025
🤖 I have created a release *beep* *boop* --- ## [9.1.4](snakemake/snakemake@v9.1.3...v9.1.4) (2025-04-01) ### Bug Fixes * Fix map call in report creation ([snakemake#3503](snakemake#3503)) ([44754cc](snakemake@44754cc)) * in the report, do not render toggle labels if there is more than one label eligible for a toggle ([snakemake#3502](snakemake#3502)) ([3be8ca9](snakemake@3be8ca9)) * only inform about storage cleanup in case of --verbose mode ([snakemake#3494](snakemake#3494)) ([62bbbf5](snakemake@62bbbf5)) * provide causing rule to workflow error during checkpoint handling ([snakemake#3499](snakemake#3499)) ([b4cbe5d](snakemake@b4cbe5d)) * rerun-trigger regression ([snakemake#3492](snakemake#3492)) ([811742d](snakemake@811742d)) ### Documentation * note about parameter inheritance when using the "use rule with" pattern ([snakemake#3500](snakemake#3500)) ([8f6a8eb](snakemake@8f6a8eb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes a small change to the
src/snakemake/report/html_reporter/template/components/abstract_results.jsfile. The change corrects the syntax for mapping overdata.toggleLabels.keys()to ensure proper functionality.data.toggleLabels.keys()in theAbstractResultsclass.Summary by CodeRabbit